Feat: Player Rating Endpoints #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add scheduled job test: add tests for rating generation chore: ad endpoints to readme
fix: add missing api param fix: make optional columns
nitzel
reviewed
May 6, 2023
fix: add missing db names to typeorm feature and root
…k-api into rating-endpoints
…the ending slash is missing
…k-api into rating-endpoints
feat: add scheduled job test: add tests for rating generation chore: ad endpoints to readme
fix: add missing api param fix: make optional columns
fix: add missing db names to typeorm feature and root
…k-api into rating-endpoints
feat: add scheduled job test: add tests for rating generation chore: ad endpoints to readme
…k-api into rating-endpoints
nitzel
reviewed
May 13, 2023
nitzel
reviewed
May 13, 2023
nitzel
reviewed
May 13, 2023
chore: add better api property descriptions
humanat
reviewed
May 15, 2023
humanat
reviewed
Nov 11, 2023
humanat
approved these changes
Nov 11, 2023
nitzel
approved these changes
Nov 11, 2023
devp
reviewed
Jun 18, 2024
devp
reviewed
Jun 18, 2024
chore: refactor to make variables more meaningful chore: refactor ratings to have better typings chore: refactor dto files chore: update formatting chore: fix typos
chore: fix typings chore: clean up player dto
devp
reviewed
Jun 19, 2024
chore: update readme
devp
approved these changes
Jun 19, 2024
…en't changed chore: add additional comments to explain the generateRatings
nitzel
reviewed
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add ratings endpoints
feat: add scheduled job
test: add tests for rating generation
chore: add endpoints to readme
Adds the following endpoints to the service:
/v1/ratings
/v1/ratings/{player_name}
Changes:
Adds the following dependency @nest/schedule