Dev to Main #12
Dev to Main #12
Conversation
feat: add scheduled job test: add tests for rating generation chore: ad endpoints to readme
fix: add missing api param fix: make optional columns
fix: add missing db names to typeorm feature and root
…k-api into rating-endpoints
…the ending slash is missing
…k-api into rating-endpoints
feat: add scheduled job test: add tests for rating generation chore: ad endpoints to readme
fix: add missing api param fix: make optional columns
fix: add missing db names to typeorm feature and root
…k-api into rating-endpoints
feat: add scheduled job test: add tests for rating generation chore: ad endpoints to readme
…k-api into rating-endpoints
chore: add better api property descriptions
chore: refactor to make variables more meaningful chore: refactor ratings to have better typings chore: refactor dto files chore: update formatting chore: fix typos
chore: fix typings chore: clean up player dto
chore: update readme
…en't changed chore: add additional comments to explain the generateRatings
Feat: Player Rating Endpoints
feat: rating list to to json file
There was a problem hiding this comment.
Awesome, I like the .bru tests!
Also crazy job you got the rating script running here! I'm still confused why fatigue can be string/Fatigue/null though ^^
It looks like the rating is neither running as a Cron nor does an endpoint exist to trigger it manually, so how are the ratings going to be calculated on production?
src/models/dto/players/player.dto.ts
Outdated
| participation_rating: number; | ||
|
|
||
| @ApiProperty() | ||
| fatigue: Fatigue | string | null; |
There was a problem hiding this comment.
What does it mean if it's a string/null?
There was a problem hiding this comment.
New registered players Fatigue is null until the rating script runs and adds it but when it gets parsed to json that where the Fatigue type comes in
There was a problem hiding this comment.
Shouldn't this be fatigue?: Fatigue then?
There was a problem hiding this comment.
@nitzel man it's a good thing I'm looking through this again from your comments I found a issue with the fatigue logic after adjusting this.
chore: code clean up and refactor
fix: update fatigue to return player fix: player type class fix: update fatigue unit test and types test: add unit test for parsing the fatigue
feat: add rating endpoints
feat: add scheduled job
test: add tests for rating generation
chore: add endpoints to readme
chore: code clean up and refactor