expand recipe Phosphorus (P) soil/agricultural to FEDEFL Phosphorus emission/soil/industrial/* #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… soil/agricultural Phosphorus (P) is a ReCiPe flowable that only affects Freshwater eutrophication. There's three contexts for this flow: freshwater, agricultural soil, and sea water. Currently, agricultural soil gets mapped to fedefl emission/ground/agricultural*. Ecoinvent also maps this agricultural soil to their soil/industrial. I think it makes sense that the original recipe flow gets also mapped to emission/soil/industrial*. The only issue is that there is no other recipe soil/agricultural being mapped to soil/industrial, so it would be one case where the context mapping is inconsistent with the context mapping so far
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new target flows for Phosphorus (P), without replacing the existing ones.
Phosphorus (P) is a ReCiPe flowable that has characterization factors in the Freshwater eutrophication impact category. There are three recipe contexts for this flowable:
freshwater,agricultural soil, andsea water.Across the recipe to fedefl mapping,
agricultural soilgets mapped to fedeflemission/ground/agricultural*. But Ecoinvent also maps theagricultural soilcontext to theirsoil/industrial. Hence the suggestion to map this particular flow soil/agricultural to emission/soil/industrial/*, this way we avoid having no impacts in this context for this flow, and we make the impacts consistent with Ecoinvent. @ErCollao @ganorris