-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of raster functionality #446
Conversation
@dbhart, can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbonney Looks good to me!
Discussion points:
|
Note to all - failed tests due to actions runner issue that still needs to be merged into main |
Ok, thanks @dbhart. Any thoughts on the first discussion point above? |
i think that we pass the filename. if the file stays open rather than loading the raster into memory then i agree that we want control over opening and close the file |
Updated docs and some minor clean up
…ta added for raster example
@kaklise, |
…ard datasets. Figure filename changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just requesting minor updates to documentation
Summary
This PR adds the function
sample_raster
to thewntr.gis
module. The function samples a raster file at the coordinate points of the provided geodataframe (e.g., junctions from WaterNetworkGIS). This PR only extends the existing API and does not modify it (ie, the inclusion of the PR merits a minor version change at most).Tests and documentation
One test is added to verify that the raster is correctly sampled. A docstring is included in the function definition. Currently no additional documentation is included, but there could be a subsection added to the Geospatial capabilities user manual page to discuss and exemplify usage of the new function.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.