Add EPANET MSX enhancements #426
Open
+8,927
−683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class will be similar to the WaterNetworkModel in terms of its structure and options.
Merge main into development branch
Citations
Update to add basic citation class
Exceptions
* Update to exception documentation * Update documentation for EN errors
…fix bugs pointed out by meghna: colorbar scale and spacing, reduce directed arrow size, add option for pumps/valves (default to not plot),
…rbar label when passing a str for attribute, fix missingkwds markersize
All os/version combos are failing in the threading test, including using the old binaries. Trying to turn off the test first to see if it can get past this test.
Pull GIS fixes into current MSX main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides updates to WNTR that integrate EPANET-MSX into the EpanetSimulator.
In addition to the new simulation options, this provides MSX model objects, such as species, terms, etc., that can be added to a water network model in a similar way to how WNTR works currently.
Demonstration is located in examples/demos/