Adding vertex plotting option to plot_network #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kbonney
commented
Nov 14, 2023
| vertices = link.vertices | ||
| if include_vertices and vertices: | ||
| node_base_name = name + "_vertex_" | ||
| link_base_name = name + "_vertexlink_" |
There was a problem hiding this comment.
vertexlink -> vertex
kbonney
commented
Nov 14, 2023
| nx.set_edge_attributes(G, name="base_link", values={(start_node, end_node, link_name): link.name}) | ||
| nx.set_node_attributes(G, name="pos", values={end_node: vertices[vertex_ind]}) | ||
| nx.set_node_attributes(G, name="type", values={end_node: "Vertex"}) | ||
| nx.set_node_attributes(G, name="base_link", values={end_node: link.name}) |
There was a problem hiding this comment.
base_link -> link_name
kbonney
commented
Nov 14, 2023
| @@ -43,7 +43,7 @@ def _format_link_attribute(link_attribute, wn): | |||
|
|
|||
| return link_attribute | |||
|
|
|||
| def plot_network(wn, node_attribute=None, link_attribute=None, title=None, | |||
| def plot_network(wn, node_attribute=None, link_attribute=None, title=None, plot_vertices=False, | |||
There was a problem hiding this comment.
plot_vertices -> include_vertices
|
Closing in favor of #451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a summary of the proposed changes, describe tests and documentation, and review the acknowledgement below.
Summary
This PR adds the ability to plot vertices to the
plot_networkfunction.Tests and documentation
Below are comparisons of the graphics generated in the current tests by plot_network with the same graphics generated with
plot_vertices=Trueto verify that the updates don't break current behavior. Note, these don't actually plot any vertices because the involved networks don't have any.:A new test using
io.inpis added to verify a network that actually have vertices:TODO
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.