Download Template #84 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added UI element and server code to download a TADA template in excel format
|
@JamesBisese I reviewed and made some changes to the upload directions. I also tried to download the template, filled in example data (attached), and uploaded it. I ran into the error you mentioned on a previous call. Error: (converted from warning) Error in dplyr::group_by: Must group by variables found in `.data`.
✖ Column `TADA.CharacteristicName` is not found.I see that this will be addressed in a separate issue/PR: #135 As mentioned there, when this example file is first brought in, these two TADA functions should be run right away to prepare it for use throughout the rest of the application: TADA_CheckRequiredFields() and then TADA_AutoClean(). TADA_AutoClean() is what creates the TADA.CharacteristicName field which is why we are getting this error.. TADA_AutoClean should be run when a user hits upload. I started working on this here: fix-option-C-#135 |
cristinamullin
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UI element and server code to download a TADA template in excel format.
This is linked to