-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added filters Country and Provider to Load tab to #164
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,25 @@ | ||
# Launch the ShinyApp (Do not remove this comment) | ||
# To deploy, run: rsconnect::deployApp() | ||
# Or use the blue button on top of this file | ||
library(devtools) | ||
|
||
pkgload::load_all(export_all = FALSE,helpers = FALSE,attach_testthat = FALSE) | ||
options( "golem.app.prod" = TRUE) | ||
TADAShiny::run_app() # add parameters here (if any) | ||
# pkgload::load_all(export_all = FALSE,helpers = FALSE,attach_testthat = FALSE) | ||
|
||
options( "golem.app.prod" = FALSE) | ||
|
||
# detach all attached packages and clean your environment | ||
golem::detach_all_attached() | ||
|
||
golem::set_golem_options() | ||
|
||
# document and reload your package | ||
golem::document_and_reload() | ||
|
||
options(shiny.launch.browser = .rs.invokeShinyWindowExternal) | ||
|
||
# TADAShiny::run_app() # add parameters here (if any) | ||
run_app() | ||
run | ||
# pkgload::load_all(export_all = FALSE,helpers = FALSE,attach_testthat = FALSE) | ||
# options( "golem.app.prod" = TRUE) | ||
# TADAShiny::run_app() # add parameters here (if any) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ default: | |
production: | ||
app_prod: yes | ||
dev: | ||
golem_wd: !expr here::here() | ||
golem_wd: !expr golem::pkg_path() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JamesBisese - I can fix/restore the unintentional changes to app.R and golem-config.yml. Once you get a chance to update the provider filter settings, I will merge this pull request. Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original check boxes work fine. In a new PR (#165), I made it so both are checked by default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesBisese - is it possible for the provider filter default setting to be both providers checked? To mimic WQP querying interface. If the user unchecks both boxes, it would be ideal to still query both providers but provide a message that both users are being queried because the user has not made any provider selection(s).