You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The TADAShiny app should not allow fatal errors to propagate from TADA and cause the app to stop functioning.
Describe the solution you'd like
(This might already be in the code base, but I can't find it yet) There should be a standard try/catch syntax that prevents fatal errors from blocking the web application.
output$graphChart<- renderPlot({
tryCatch({
plot(rules())
}, warning=function(w) {
showNotification('there was a warning','',type="error")
return()
}, error=function(e) {
showNotification('there was an error','',type="error")
return()
}, silent=TRUE)
})
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features
you've considered.
Additional context
Building up my understanding of observables - there is no linear trapping of errors. It can be done on the 'TADA' function calls, but it needs to be done such that the observables are reviewed and errors trapped when they are being processed.
Reminders for TADA contributors addressing this issue
New features and/or edits should include the following work:
Create or edit the code.
Document all code using line/inline and/or multi-line/block comments
to describe what is does.
Create or edit tests in tests/testthat folder to help prevent and/or
troubleshoot potential future issues.
If your code edits impact other functionality in the shiny
app, ensure those are updated as well.
Run styler::style_pkg(), devtools::document(), and devtools::check()
and address any new notes or issues before creating a pull request.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The TADAShiny app should not allow fatal errors to propagate from TADA and cause the app to stop functioning.
Describe the solution you'd like
(This might already be in the code base, but I can't find it yet) There should be a standard try/catch syntax that prevents fatal errors from blocking the web application.
I will try to implement based on https://stackoverflow.com/questions/62997745/trycatch-error-handling-doesnt-work-in-shiny-app
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features
you've considered.
Additional context
Building up my understanding of observables - there is no linear trapping of errors. It can be done on the 'TADA' function calls, but it needs to be done such that the observables are reviewed and errors trapped when they are being processed.
Reminders for TADA contributors addressing this issue
New features and/or edits should include the following work:
Create or edit the code.
Document all code using line/inline and/or multi-line/block comments
to describe what is does.
Create or edit tests in tests/testthat folder to help prevent and/or
troubleshoot potential future issues.
If your code edits impact other functionality in the shiny
app, ensure those are updated as well.
Run styler::style_pkg(), devtools::document(), and devtools::check()
and address any new notes or issues before creating a pull request.
The text was updated successfully, but these errors were encountered: