Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upload Excel file without TADA.CharacteristicName field #177

Open
5 tasks
JamesBisese opened this issue Nov 25, 2024 · 2 comments
Open
5 tasks
Assignees

Comments

@JamesBisese
Copy link
Collaborator

JamesBisese commented Nov 25, 2024

Describe the bug

When trying to import a TADA export where the TADA.* fields are removed, a fatal error occurs and the app stops

To Reproduce

Steps to reproduce the behavior:

1. Go to 'TADAShiny'

2. Load testing data-set Nutrients Utah

3. Export the working data

3. Edit working data Excel file and remove all the fields with column headers starting with TADA.*

4. In TADAShiny upload the edited file

5. See the screen shows the app has died, even though the 'Success' message is displayed

image

6. See the error message printed in the RStudio Console window

Error: (converted from warning) Error in dplyr::group_by: Must group by variables found in .data.
✖ Column TADA.CharacteristicName is not found.

7. Make sure that the warn setting is not causing this. This is a setting which controls how TADAShiny reacts to having warning messages occur.

options(warn = 1)
TADAShiny::run_app();

Listening on http://127.0.0.1:4608
Warning: Error in dplyr::group_by: Must group by variables found in .data. -- Not that there is no 'converted from warning' message.
✖ Column TADA.CharacteristicName is not found.
3: runApp
2: print.shiny.appobj
1:

Expected behavior

The Success message should not have been displayed. An error message should be displayed to the user.
(Actually, no error should have occurred - the TADA.* fields should not be required for an import file)

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

This must be happening as a step after upload. When it is preparing a chart or graph of some kind that uses the TADA.CharacteristicName field.

Tested by removing only the TADA.ActivityMediaName field. And this was successful.

Reminders for TADA contributors addressing this issue

Bug fixes should include the following work:

  • Create or edit the code.

  • Document all code using line/inline and/or multi-line/block comments
    to describe what is does.

  • Create or edit tests in tests/testthat folder to help prevent and/or
    troubleshoot potential future issues.

  • If your code edits impact other functionality in the shiny
    app, ensure those are updated as well.

  • Run styler::style_pkg(), devtools::document(), and devtools::check()
    and address any new notes or issues before creating a pull request.

@JamesBisese JamesBisese self-assigned this Dec 5, 2024
@JamesBisese
Copy link
Collaborator Author

This is ALMOST entirely covered under "Need a way to trap errors generated in TADA and prevent them from stopping TADAShiny #179" this is a specific case of implementing the error trapping.
LOE 4-6 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants