-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown veg_ values cause issues in albedo decay methods #215
base: release-0.9
Are you sure you want to change the base?
Unknown veg_ values cause issues in albedo decay methods #215
Conversation
micah-prime
commented
Nov 11, 2021
- add test showing that albedo config parses unknown veg_ values as a list of strings rather than a float.
- Update requirements for breaking build. use_2to3 is not allowed with latest setuptools
- Address issue Unknown veg_ values cause issues in albedo decay methods #214
…ist of strings rather than a float. Update requirements for breaking build. use_2to3 is not allowed with latest setuptools
@Hedrick-ARS @jomey @scotthavens Also, does release-0.9 still build? |
@@ -23,7 +23,7 @@ oset==0.1.3 | |||
pandas==0.22.0 | |||
pbr==3.1.1 | |||
progressbar2==3.6.2 | |||
pybtex==0.21 | |||
pybtex==0.24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version 0.21 won't build with the latest setup tools due to use_2to3
being a deprecated option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this package needed and where is it used? The current version removed a lot of requirements that aren't needed.
Don't have enough insights for the 0.9 release. What is the motivation to have this only changed in an older release? |
@jomey it should be fixed in the newer release as well. I can take a look at that soon. I just started with the stable version. |
We ran out of credits on Travis and they won't give us more so we moved to GH actions. This won't build anymore so you'll have to limp this along until a new release can be cut. Let's discuss this in #214 as I don't see the reason for the fix yet. |