Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSM daily running 1 more hour than needed #87

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

scotthavens
Copy link
Contributor

updated from 24 hours to 23 hours fix #55

@jomey
Copy link
Collaborator

jomey commented Mar 30, 2021

Can we merge this?

I am currently going through the SMRF outputs and it requires an additional filter for each day to exclude the extra time step at 00:00 for the next day.

@scotthavens scotthavens merged commit 83c613a into release-0.10 Mar 30, 2021
@scotthavens
Copy link
Contributor Author

Forgot about this one!

@jomey
Copy link
Collaborator

jomey commented Mar 30, 2021

Thank you!

@scotthavens
Copy link
Contributor Author

FYI, this should be fixed already in the main branch.

@jomey
Copy link
Collaborator

jomey commented Mar 30, 2021

FYI, this should be fixed already in the main branch.

Hm ... Does not look like it

New PR?

@scotthavens
Copy link
Contributor Author

Hmm, guess "fixed" was a relative term.

I don't think that the daily is setup to run how it once was, I'd have to check as I was making a lot of changes to the way AWSM was ran. Off the top of my head, you should be able to run it in a daily mode but write to the same netcdf output files, bypassing the daily folders. It should also have written out to daily folders but the script may not have been fixed.

@jomey
Copy link
Collaborator

jomey commented Mar 30, 2021

Trying to follow your train of thought.

I have daily outputs, but basically each day also has a '00:00' hour for the next day. This I attributed to this fix, where SMRF was given 25 hours. Is that correct?

Will there be a different behavior on main, no longer producing daily output files?

@scotthavens
Copy link
Contributor Author

Haven't been in AWSM/SMRF world for a while... But yes, this was merged to release-0.10 which will remove the 00:00 hour from the daily SMRF files.

In main, I started with making sure the AWSM would run in the standard start/end date folder structure and the output files would be appended. This is intended to replace the daily folder and make it easier to work with the files, especially when using HRRR. However, I don't think I've finished the daily AWSM folder creation that would make it like how you and release-0.10 are running.

@scotthavens scotthavens deleted the 55_awsm_daily_airflow branch March 30, 2021 15:33
jomey referenced this pull request in UofU-Cryosphere/awsm Apr 1, 2021
Transferring fix for issue #87 and run only hours of the same day.
jomey referenced this pull request in UofU-Cryosphere/awsm May 18, 2021
Transferring fix for issue #87 and run only hours of the same day.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants