CTO-118 Updated Gate Change Controller and DAO #904
Conversation
…hanges store/delete functionality
| CWMS_OUTLET_PACKAGE.call_DELETE_OUTLET(DSL.using(conn).configuration(), locationId, | ||
| deleteRule.getRule(), officeId); | ||
| } catch (IntegrityConstraintViolationException e) { | ||
| throw new NotFoundException(e); |
There was a problem hiding this comment.
Not found doesn't make sense given the parent exception. 409 Conflict https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/409 makes more sense.
There was a problem hiding this comment.
Swapped for a DeleteConflictException. The error code received by HCDA isn't the most useful, ("Data already exists for this request"). Maybe there's another exception that will provide more detail?
There was a problem hiding this comment.
It should send basically what the constraint is "something depends on it." We'll have to look into that later.
| @@ -199,6 +199,7 @@ static GateChange buildTestGateChange(CwmsId projectId, Instant changeDate, Gate | |||
| .withNotes(notes) | |||
| .withChangeDate(changeDate) | |||
| .withSettings(settings) | |||
| // .withType("gate-change") | |||
There was a problem hiding this comment.
Either delete if not needed, or provide explanation of why it's sitting here commented out (in the comment itself.)
There was a problem hiding this comment.
Deleted unnecessary comment
| "type" : "gate-change", | ||
| "project-id" : { | ||
| "office-id" : "SPK", | ||
| "name" : "PROJECT1" |
There was a problem hiding this comment.
use a "real" project name.
There was a problem hiding this comment.
Swapped for a project name used in other Outlet testing
| "type" : "gate-setting", | ||
| "location-id" : { | ||
| "office-id" : "SPK", | ||
| "name" : "PROJECT1-CG100" |
There was a problem hiding this comment.
same as above comment, use a "real" name.
There was a problem hiding this comment.
Swapped for a project name used in other Outlet testing
|
There are failing tests, but they look unrelated to this PR so I'm merging in anyways. |
Updated Gate Change Controller and DAO to support operation changes store/delete functionality