Issue 886 - Updated LocationGroup and TimeSeriesGroup patch #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack-rma
requested review from
adamkorynta,
MikeNeilson,
RyanM-RMA and
rma-psmorris
MikeNeilson
requested changes
Oct 4, 2024
cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesGroupController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/TimeSeriesGroupControllerTestIT.java
Outdated
Show resolved
Hide resolved
adamkorynta
reviewed
Oct 4, 2024
cwms-data-api/src/main/java/cwms/cda/api/LocationGroupController.java
Outdated
Show resolved
Hide resolved
adamkorynta
requested changes
Oct 4, 2024
cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesGroupController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/LocationGroupControllerTestIT.java
Outdated
Show resolved
Hide resolved
adamkorynta
requested changes
Oct 7, 2024
adamkorynta
previously approved these changes
Oct 8, 2024
MikeNeilson
previously approved these changes
Oct 9, 2024
zack-rma
force-pushed
the
bugfix/ts_patch_issue_886
branch
from
ed4c804
to
06a35b7
Compare
|
Rebased to fix build errors |
adamkorynta
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #886 - Updated LocationGroup and TimeSeriesGroup patch office handling to allow for assigning non-CWMS TS/locations to a CWMS-owned group