Feature/remove deprecated #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king for the params in the requests.
…king for the params in the requests.
|
I'm thinking that this should also bump the version from 3.0 to 3.1 ? thoughts? |
|
There should be a review of the CWMS 3.3.0 and CWMS 3.3.1 usage. Should also review that the CDA client repo isn't using the deprecated parameters. |
|
The needed CWMS changes have been done. This PR is ready. |
MikeNeilson
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes query params that were previously marked as deprecated except for the two places using deprecated "format" params. I think the format params should be handled in a different way.
This relates to contract W912HQ22F0193 Task 8 Topic A.