Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops/test updates #439

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Devops/test updates #439

merged 3 commits into from
Sep 21, 2023

Conversation

MikeNeilson
Copy link
Contributor

Ran the integration tests and discovered some preconditions had changed.

Would be good to figure out exactly why but it's not as important to this test so long as pagination is forced.

Also did a little cleanup while I was at it.

Less than 500 results were now being returned. Changed to 200 to better force pagination.
- Line up given/<METHOD>/then to make the given/when/then concept of the tests a little more clear.
- Set to output with pretty print on validation failure.
- Corrected whitespace.
@MikeNeilson MikeNeilson added hec-approved-W912HQ22F0913-13b only valid if created by @MikeNeilson priority:medium We care, and will try and get to it soon. labels Sep 20, 2023
@MikeNeilson MikeNeilson merged commit b96ef1b into develop Sep 21, 2023
3 checks passed
@MikeNeilson MikeNeilson deleted the devops/test_updates branch September 21, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hec-approved-W912HQ22F0913-13b only valid if created by @MikeNeilson priority:medium We care, and will try and get to it soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants