-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated libocpp patch #28
Integrated libocpp patch #28
Conversation
Signed-off-by: louisg1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@louisg1337 we should clean up this patch a bit before having others review it. Concretely, we should:
- downgrade all the
EVLOG_error
s toEVLOG_warning
orEVLOG_info
or... - remove out unnecessary commented out code
- make the
MessageType::SetChargingProfile
handling be similar to the others
A lot of this was hacking the code together to figure out what was going on, we should clean it up before submission
Signed-off-by: louisg1337 <[email protected]>
Signed-off-by: louisg1337 <[email protected]>
Signed-off-by: louisg1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drmrd @couryrr-afs @wjmp please let us know if AFS is able to and wants to review this. Otherwise, we will just merge!
This looks fine to me for the demo code. |
Note that we are requesting to merge this into the main libocpp, not into the demo code. |
I am going to merge this in the next few days |
@shankari we are actively working on this implementation with test coverage. |
ok I will merge this change, we can submit to the main everest repo once the tests are done! |
@louisg1337 can you please change this to point to the |
@shankari new PR which points to |
Describe your changes
This PR integrates the
libocpp.patch
file that is currently being using in thecharin-e2e-demo
. The goal is to completely get rid of all of the patches so that thecharin-e2e-demo
can be fully functional and not rely on hacky patches.Testing Done
This code was tested alongside all of the other patches in
everest-demo/charin-e2e-demo
. In the demo,setChargingProfile
, which this patch helps implement, seems to work on a basic level.Issue ticket number and link
The issue that this is related to can be found here.
Checklist before requesting a review