Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ROT13 Command #170

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Create ROT13 Command #170

merged 3 commits into from
Jan 16, 2024

Conversation

bradleysigma
Copy link
Contributor

@bradleysigma bradleysigma commented Oct 23, 2023

Create ROT 13 command. Semi-imported from the Slack !caesar command. Can be used as an alternative to ||spoilers||, with the distinction that the general shape of the message can be seen e.g. below the first use is identifiable as enciphering a URL. Has a context menu option, which responds with an ephemeral message; only shows the (probable) decryption to the user that called it, instead of publishing to the entire channel. Discord bots are limited to five context menu listings (for some reason), so either the context menu version of Zalgo or Mock (or both) would have to be removed for this to be added; both are currently commented out, but could uncomment one if there is a consensus. This has a meaningful usecase for the context menu version (to privately decrypt a version encrypted with the slash version), which Zalgo is kinda lacking.

image

@bradleysigma
Copy link
Contributor Author

Another difference it has to ||spoiler|| is that for this, you have the option to use an external tool to decode the message word by word, if you wish to attempt to see where a message is going and possibly cut yourself off part way though, instead of only having the option to reveal the entire message as a whole.

uqcsbot/text.py Show resolved Hide resolved
uqcsbot/text.py Show resolved Hide resolved
uqcsbot/text.py Show resolved Hide resolved
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending discussion on context menu.

I'll add it to our infra to-do-list; we're currently at the limit of 5 commands (3 from text.py, plus the mod-only starboard blacklist/whitelist commands).

@bradleysigma
Copy link
Contributor Author

I'll add it to our infra to-do-list

What's longer, the Infra to-do list, or @LimaoC's Outgoing Secretary to-do list?

@LimaoC
Copy link
Member

LimaoC commented Oct 28, 2023

@LimaoC's Outgoing Secretary to-do list

No such list exists, this is a fabricated lie made up by @bradleysigma

@bradleysigma
Copy link
Contributor Author

But here you give confirmation of the list's existence; were you lying then or are you lying now?
image

@andrewj-brown
Copy link
Member

andrewj-brown commented Oct 28, 2023

I'll add it to our infra to-do-list

What's longer, the Infra to-do list, or @LimaoC's Outgoing Secretary to-do list?

Presumably the infra list, which is currently at 23 items (plus sub-items).

Our plan is to hold a meeting sometime within a month, so hopefully this PR doesn't have to wait too long. I've converted to draft as an interim measure.

@andrewj-brown andrewj-brown added the question Further information is requested label Oct 28, 2023
@andrewj-brown andrewj-brown marked this pull request as draft October 28, 2023 02:12
@andrewj-brown andrewj-brown added awaiting-discussion needs infra/committee discussion to progress and removed question Further information is requested labels Oct 28, 2023
@andrewj-brown andrewj-brown marked this pull request as ready for review January 16, 2024 09:03
@andrewj-brown andrewj-brown merged commit 411757e into main Jan 16, 2024
3 checks passed
@andrewj-brown andrewj-brown deleted the rot-13 branch January 16, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-discussion needs infra/committee discussion to progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants