Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Whatweekisit Flavour Text #163

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Added Whatweekisit Flavour Text #163

merged 3 commits into from
Sep 26, 2023

Conversation

49Indium
Copy link
Member

@49Indium 49Indium commented Sep 21, 2023 •
edited
Loading

Added random messages to make /whatweekisit more fun.

@49Indium 49Indium changed the title Added Whatweekisit lavour text Added Whatweekisit Flavour Text Sep 21, 2023
andrewj-brown
andrewj-brown previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Curious about the duplication, though. Seems redundant to say "It's currently week 9: Thursday, Week 9 of Semester 2".

Two more suggestions:

Good heavens, would you look at the time:
What's the time, mister wolf? It's:

@ew-b
Copy link
Contributor

ew-b commented Sep 21, 2023

Lgtm!

andrewj-brown
andrewj-brown approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L 🅱️ TM

@andrewj-brown andrewj-brown merged commit cd5b338 into main Sep 26, 2023
3 checks passed
@49Indium 49Indium deleted the whatweekisit branch November 30, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewj-brown andrewj-brown andrewj-brown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@49Indium @ew-b @andrewj-brown