Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dominos coupons command #128

Merged
merged 7 commits into from
Jul 2, 2023
Merged

Added dominos coupons command #128

merged 7 commits into from
Jul 2, 2023

Conversation

49Indium
Copy link
Member

Added the previously unimplemented dominoscoupons command. Returns a list of dominos coupons from couponese. Heavily inspired by @bradleysigma's previous implementation for the slack bot.

Also completes part of #1.

Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor points - nothing blocking merge. Git seems to have done a funny and not included your 3 latest commits into this PR; I was unable to rectify that by opening a replacement (because this one is still linked).

So I guess whoever merges this, beware and make sure all dominos commits are included, which may require closing this PR and opening a new one to merge.

uqcsbot/dominos_coupons.py Outdated Show resolved Hide resolved
uqcsbot/dominos_coupons.py Outdated Show resolved Hide resolved
uqcsbot/dominos_coupons.py Show resolved Hide resolved
@andrewj-brown andrewj-brown mentioned this pull request Jul 1, 2023
@49Indium 49Indium added the enhancement update an existing command or cog for some new functionality label Jul 2, 2023
Copy link
Member

@JamesDearlove JamesDearlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, lgtm

@49Indium 49Indium merged commit f8f4a27 into main Jul 2, 2023
@49Indium 49Indium deleted the dominos branch July 2, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement update an existing command or cog for some new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants