Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left panel file ordering fixed #1

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

GrecuAlexandru
Copy link

lapce#2730 fixed

lukaslihotzki and others added 22 commits November 29, 2023 17:23
* Line-wrap impl

* Fix paint normal selection around linewrapping and phantom text

* Fix linewise selection

* Maybe fix scroll bug

* Fix breakpoint positioning

* Clippy fixes

* Docs + Fixes + Cleanup

* Make phantom text before_col more indirect

This will be useful once we stop aggressively computing the full PhantomText whenever it is accessed.

* Make over-monomorphizations over TextLayoutProvider less likely

* Fix bench
* Initial basic save backend

* Trait extension, move history to backend

* Move diagnostics to Document backend

* Move inlay hints to Document backend

* Move completion lens to Document backend

* Move code actions to Document backend

* Move syntax/semantic highlighting to Document backend

* Move breakpoints to Document backend

* Rename ProxyBackend -> DocBackend

* Update floem
* Remove LapceConfig requirement on do_insert

* Remove lsp max_severity DiagnosticSeverity from phantom text
* Implement UI for renaming files

Implement functionality for renaming files and directories in lapce-app, accessible by right clicking the item in the file explorer and selecting "Rename...".

Backend functionality for file renaming in lapce-proxy was already present and is unchanged.

If the rename fails, the name is not updated in the file explorer and no error is reported.

Open editors are not notified of the rename. If the user saves the contents of an already open editor after performing a rename, the file will be saved in its original location.

* Improve file renaming functionality

* When renaming, lapce-proxy is now queried on each keystroke to see if the new path is valid and errors are reported to the user.

* If a rename operation fails, the rename text box stays open and the error is reported to the user.

* When renaming a file, any buffers or editors the renamed file is open in are updated to use the new path.

* When renaming a directory, any buffers or editors a file the renamed directory is an ancestor of is open in are updated to use the new path.

* Non existing ancestor directories of the new path are created on rename.
* fix: Display untracked files on a fresh git repository.

Issue lapce#2779.

Known issue: files without history are displaying text-less diff.

* fix: Display untracked files on a fresh git repository.

Issue lapce#2779.

Known issue: files without history are displaying text-less diff.

* fix: clippy warnings

* fix: clippy errors

---------

Co-authored-by: Alexandre Leblanc <[email protected]>
* fix: Commit on freshly initialized repository.

Fixes lapce#2779

* fix: Prompt error message when Git user.name or user.email is missing.

Fixes lapce#1277.

* Update CHANGELOG.md

---------

Co-authored-by: Alexandre Leblanc <[email protected]>
@GrecuAlexandru GrecuAlexandru marked this pull request as ready for review January 5, 2024 18:16
dzhou121 and others added 4 commits January 5, 2024 21:25
So we need to move it out of update() so that it doesn't
cause the already borrowed crash
The user can either:

* Select the files to compare by right clicking on them in the file explorer.

* Invoke the `diff_files` command and select the files to compare from the palette.

Fix double clicking on an unconfirmed diff editor tab not confirming it.
@alexandruradovici
Copy link

Looks good, send it to upstream and post a link to the pull request here.

@GrecuAlexandru
Copy link
Author

lapce#2912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants