forked from lapce/lapce
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left panel file ordering fixed #1
Open
GrecuAlexandru
wants to merge
29
commits into
UPB-CS-OpenSourceUpstream:master
Choose a base branch
from
GrecuAlexandru:open_source_contribution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Left panel file ordering fixed #1
GrecuAlexandru
wants to merge
29
commits into
UPB-CS-OpenSourceUpstream:master
from
GrecuAlexandru:open_source_contribution
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Line-wrap impl * Fix paint normal selection around linewrapping and phantom text * Fix linewise selection * Maybe fix scroll bug * Fix breakpoint positioning * Clippy fixes * Docs + Fixes + Cleanup * Make phantom text before_col more indirect This will be useful once we stop aggressively computing the full PhantomText whenever it is accessed. * Make over-monomorphizations over TextLayoutProvider less likely * Fix bench
* Initial basic save backend * Trait extension, move history to backend * Move diagnostics to Document backend * Move inlay hints to Document backend * Move completion lens to Document backend * Move code actions to Document backend * Move syntax/semantic highlighting to Document backend * Move breakpoints to Document backend * Rename ProxyBackend -> DocBackend * Update floem
* Remove LapceConfig requirement on do_insert * Remove lsp max_severity DiagnosticSeverity from phantom text
* Implement UI for renaming files Implement functionality for renaming files and directories in lapce-app, accessible by right clicking the item in the file explorer and selecting "Rename...". Backend functionality for file renaming in lapce-proxy was already present and is unchanged. If the rename fails, the name is not updated in the file explorer and no error is reported. Open editors are not notified of the rename. If the user saves the contents of an already open editor after performing a rename, the file will be saved in its original location. * Improve file renaming functionality * When renaming, lapce-proxy is now queried on each keystroke to see if the new path is valid and errors are reported to the user. * If a rename operation fails, the rename text box stays open and the error is reported to the user. * When renaming a file, any buffers or editors the renamed file is open in are updated to use the new path. * When renaming a directory, any buffers or editors a file the renamed directory is an ancestor of is open in are updated to use the new path. * Non existing ancestor directories of the new path are created on rename.
* fix: Display untracked files on a fresh git repository. Issue lapce#2779. Known issue: files without history are displaying text-less diff. * fix: Display untracked files on a fresh git repository. Issue lapce#2779. Known issue: files without history are displaying text-less diff. * fix: clippy warnings * fix: clippy errors --------- Co-authored-by: Alexandre Leblanc <[email protected]>
* fix: Commit on freshly initialized repository. Fixes lapce#2779 * fix: Prompt error message when Git user.name or user.email is missing. Fixes lapce#1277. * Update CHANGELOG.md --------- Co-authored-by: Alexandre Leblanc <[email protected]>
So we need to move it out of update() so that it doesn't cause the already borrowed crash
The user can either: * Select the files to compare by right clicking on them in the file explorer. * Invoke the `diff_files` command and select the files to compare from the palette. Fix double clicking on an unconfirmed diff editor tab not confirming it.
Looks good, send it to upstream and post a link to the pull request here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lapce#2730 fixed