added partial solution #12

razvanrus2003 · 2024-01-20T10:19:29Z

#5
-added support for utf8 characters for save and find commands.
-highlight bugs for fullwidth characters

razvanrus2003 · 2024-01-20T11:41:44Z

-fixed highlight bug by using unicode_width crate to determine String display width instead of the number of bits/characters

razvanrus2003 · 2024-01-20T13:52:45Z

-final solution

alexandruradovici

Please fix the build issues.

alexandruradovici

Please send the pull request to upstream and put a link to it here.

razvanrus2003 · 2024-01-21T14:16:44Z

ilai-deutel#281
here

* -2 lines * modified macro, -2 lines

Bumps [libc](https://github.com/rust-lang/libc) from 0.2.152 to 0.2.153. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](rust-lang/libc@0.2.152...0.2.153) --- updated-dependencies: - dependency-name: libc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.9.0 to 3.10.0. - [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md) - [Commits](Stebalien/tempfile@v3.9.0...v3.10.0) --- updated-dependencies: - dependency-name: tempfile dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.10.0 to 3.10.1. - [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md) - [Commits](Stebalien/tempfile@v3.10.0...v3.10.1) --- updated-dependencies: - dependency-name: tempfile dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [unicode-width](https://github.com/unicode-rs/unicode-width) from 0.1.11 to 0.1.12. - [Commits](unicode-rs/unicode-width@v0.1.11...v0.1.12) --- updated-dependencies: - dependency-name: unicode-width dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [winapi-util](https://github.com/BurntSushi/winapi-util) from 0.1.6 to 0.1.8. - [Commits](BurntSushi/winapi-util@0.1.6...0.1.8) --- updated-dependencies: - dependency-name: winapi-util dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [libc](https://github.com/rust-lang/libc) from 0.2.153 to 0.2.155. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](rust-lang/libc@0.2.153...0.2.155) --- updated-dependencies: - dependency-name: libc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [libc](https://github.com/rust-lang/libc) from 0.2.158 to 0.2.159. - [Release notes](https://github.com/rust-lang/libc/releases) - [Changelog](https://github.com/rust-lang/libc/blob/0.2.159/CHANGELOG.md) - [Commits](rust-lang/libc@0.2.158...0.2.159) --- updated-dependencies: - dependency-name: libc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.12.0 to 3.13.0. - [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md) - [Commits](Stebalien/tempfile@v3.12.0...v3.13.0) --- updated-dependencies: - dependency-name: tempfile dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serial_test](https://github.com/palfrey/serial_test) from 3.0.0 to 3.1.1. - [Release notes](https://github.com/palfrey/serial_test/releases) - [Commits](palfrey/serial_test@v3.0.0...v3.1.1) --- updated-dependencies: - dependency-name: serial_test dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Ilaï Deutel <[email protected]>

* update README.md [skip ci] * update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Bug Reproduction: rm foo.txt; kibi foo.txt

…utel#336)

Saves 4 LOG

* update README.md [skip ci] * update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

This makes vscode automatically use the correct formatting when saving

…ilai-deutel#338)

…tel#341) This enables the use of sanitizers

Signed-off-by: Ilaï Deutel <[email protected]>

See mbrobbel/rustfmt-check#1137

…es (ilai-deutel#330) Saves 1 LOC

* Replace count_loc.sh with xtask To run the count_loc now, you can use `cargo xtask count-loc` instead of `./count_loc.sh`. See <https://github.com/matklad/cargo-xtask> for more info on cargo-xtask. Fixes: ilai-deutel#323 * Only check formatting on main package, not xtask There's a +nightly oddity where it returns an empty array twice instead of valid json for multiple projects, this causes the check action to fail

Signed-off-by: Ilaï Deutel <[email protected]>

Signed-off-by: Alexander Zaitsev <[email protected]>

* add test for pressing the home key

* update README.md [skip ci] * update .all-contributorsrc [skip ci] --------- Signed-off-by: Ilaï Deutel <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Ilaï Deutel <[email protected]>

Signed-off-by: Ilaï Deutel <[email protected]>

razvanrus2003 added 2 commits January 20, 2024 12:08

added partial solution

31a7f70

better highlight length getter (using unicode_width)

f63bcdb

finnished coding style

7df0d7a

alexandruradovici requested changes Jan 21, 2024

View reviewed changes

fixed warnings

755da5a

alexandruradovici approved these changes Jan 21, 2024

View reviewed changes

razvanrus2003 and others added 21 commits January 21, 2024 21:07

Lines optimization (ilai-deutel#280)

57268a2

* -2 lines * modified macro, -2 lines

add auzkok as contributor for syntax-highlighting (ilai-deutel#278)

c919b27

[CI] Fail on Clippy error (ilai-deutel#283)

991dc7b

Merge branch 'master' into utf8_prompts

945b3e6

[CI] Actually fail on Clippy error (ilai-deutel#284)

8966c46

Bump libc from 0.2.155 to 0.2.158 (ilai-deutel#301)

e08fcc4

Bump tempfile from 3.10.1 to 3.12.0 in /fuzz (ilai-deutel#299)

306b115

Bump winapi-util from 0.1.8 to 0.1.9 (ilai-deutel#302)

8c607d6

Bump MSRV to Rust 1.65.0 (ilai-deutel#306)

44bf29a

But MSRV to 1.66.0 (ilai-deutel#307)

06bba14

ilai-deutel and others added 30 commits November 13, 2024 10:39

Update README.md - HelloGitHub claim

f989f6f

Signed-off-by: Ilaï Deutel <[email protected]>

add joshka as a contributor for infra (ilai-deutel#324)

5297230

* update README.md [skip ci] * update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

fix: crash when opening a new file (ilai-deutel#287)

e33d26f

Bug Reproduction: rm foo.txt; kibi foo.txt

[CI] Configure secret token for reviewdog (ilai-deutel#332)

cb13bce

[Clippy] Check in config, update CI (ilai-deutel#333)

be558cf

Combine mod xdg with cfg(any) (LOC -= 1) (ilai-deutel#335)

cce6e93

[Clippy] Add nursery-level warnings, fix issues found (ilai-deutel#334)

1422e1e

Fix formatting and Clippy workflows outside of pull requests (ilai-de…

4f0d79c

…utel#336)

Replace Key::Page(PageKey) with Key::Page{Up,Down} (ilai-deutel#331)

b7167e7

Saves 4 LOG

add joshka as a contributor for code (ilai-deutel#337)

cc7ec3a

* update README.md [skip ci] * update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Add vscode settings for using nightly rustfmt (ilai-deutel#329)

e02145f

This makes vscode automatically use the correct formatting when saving

[CI] Update security workflows, add cargo-deny, deprecate cargo-audit (…

d3a4843

…ilai-deutel#338)

Fix config parsing with invalid durations (ilai-deutel#340)

50944c6

Bump MSRV to 1.80 (ilai-deutel#343)

aa31bf9

[Tests] Remove dependency on serial_test, use Mutex instead (ilai-deu…

b5dcbf5

…tel#341) This enables the use of sanitizers

Fix markdownlint errors in README.md

c24668b

Delete .github/workflows/devskim.yml

cf2dc81

Signed-off-by: Ilaï Deutel <[email protected]>

Add weekly sanitizer run to CI (ilai-deutel#342)

2b9aa5d

[CI] Temporarily stop using mbrobbel/rustfmt-check

2a5840e

See mbrobbel/rustfmt-check#1137

Use module paths instead of conditional module includes for sys modul…

edcba19

…es (ilai-deutel#330) Saves 1 LOC

[xtask] Add more info to Cargo.toml (ilai-deutel#344)

5eff635

Fix lint config for main crate

382b422

Remove obsolete TODO

7456225

Signed-off-by: Ilaï Deutel <[email protected]>

Add more lints to check and clippy configuration (ilai-deutel#345)

7bedad6

feat: enable LTO (ilai-deutel#346)

a03e7c2

Signed-off-by: Alexander Zaitsev <[email protected]>

add zamazan4ik as a contributor for infra (ilai-deutel#347)

9f0cf2c

Adding test for home + end keys (ilai-deutel#311)

1628b51

* add test for pressing the home key

Merge branch 'master' into utf8_prompts

0748dbe

Signed-off-by: Ilaï Deutel <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added partial solution #12

added partial solution #12

razvanrus2003 commented Jan 20, 2024 •

edited

Loading

razvanrus2003 commented Jan 20, 2024

razvanrus2003 commented Jan 20, 2024 •

edited

Loading

alexandruradovici left a comment

alexandruradovici left a comment

razvanrus2003 commented Jan 21, 2024

added partial solution #12

Are you sure you want to change the base?

added partial solution #12

Conversation

razvanrus2003 commented Jan 20, 2024 • edited Loading

razvanrus2003 commented Jan 20, 2024

razvanrus2003 commented Jan 20, 2024 • edited Loading

alexandruradovici left a comment

Choose a reason for hiding this comment

alexandruradovici left a comment

Choose a reason for hiding this comment

razvanrus2003 commented Jan 21, 2024

razvanrus2003 commented Jan 20, 2024 •

edited

Loading

razvanrus2003 commented Jan 20, 2024 •

edited

Loading