Account #196
Closed
Account #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes all routine calls that wanted a specific type of stream ifstream/ofstream to the generic istream/ostream. So you can use stringstream, or other derived types.
Modernizes the way LoadResource and SaveResource works in regions. Added a missing forward declare in MultiMul.h
… just reinitialize the entire vector, based on the default values, and then just update the values that are in the file.
move version as part of transistion, and made it just const std::stirngs Console was renamed, moved,, and made a singleton
Account changes Starting to unwind the header hell
Address a cast issue (non account) in uoxstruct.h Addressed cast in gumps (account issue) Corrected jscript project, to not include two files that where for stand alone programs (and resulted in main being added twice in the library (and once was incorrect all ready).
Xoduz
added
the
nomerge - future ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following:
Replaces cAccountClass with Account (modern c++)
Makes Account a singleton(as you can't have more then one, and you want global access).
This is based on the PR before it.
Note: this did not fundamentally change the interaction of the rest of the UOX3 system with Account management. Did not increase/decrease the isolation factor. Mainly focused on getting Account to be less "C ish".
Unrelated to Account functionality but included in this PR.
Fixed spidermonkey cmake build - added warning to quite build on unix, remove two files that where not needed and introducing "main" routines into the library
Fixed vs2022 spider monkey project to remove the two files
Fixed an memory overflow issue in MultiMul.cpp