Singleton #195
Closed
Singleton #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes all routine calls that wanted a specific type of stream ifstream/ofstream to the generic istream/ostream. So you can use stringstream, or other derived types.
Modernizes the way LoadResource and SaveResource works in regions. Added a missing forward declare in MultiMul.h
… just reinitialize the entire vector, based on the default values, and then just update the values that are in the file.
move version as part of transistion, and made it just const std::stirngs Console was renamed, moved,, and made a singleton
Xoduz
added
the
nomerge - future ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off utility PR
In prep for the account merge, two "singletons" were made. Console and Version
Version was made to just be a const std::string wrapper in a stuct (could have been a namespace as well).
Console was made into a singleton.
Starts the unwinding of all the externals in uox3. In console case, it really is a singleton, as you can't have more than one of them.
Also noticed that the thread "cons" was not joined on exit so added that. I think there is still another thread that isn't being joined, but wasn't the focus of this branch.
Essentially no functionality was changed with this at all. For most of the code, Console got a Console::shared(), and the version was renamed and dropped the () on the methods.