Regionmarkers - Xuri, please just benchmark two ways, see notes #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes all routine calls that wanted a specific type of stream ifstream/ofstream to the generic istream/ostream. So you can use stringstream, or other derived types.
Modernizes the way LoadResource and SaveResource works in regions. Added a missing forward declare in MultiMul.h
… just reinitialize the entire vector, based on the default values, and then just update the values that are in the file.
Removed region markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really nothing more then adding a switch for turning off console writing (on save),
and removing region markers from the save files.
Also code as been adapted to the auto syntax.
This was a branch right before I started work on binary threaded saves (well, binary to the thread, text to the disk)
Xuri, this should not be merged. Can you please benchmark this timewise on your large saves?
Also, can you go to regions.cpp, at the top, and comment out this: #define SAVE_CONSOLE (around line 16).
Then run again. That elimiantes the console writing on the region saves, just to get a feel of how much Console time is costing.
Thank you as always.