Stream update #189
Closed
Stream update #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplifed workflow into one
Develop into RC
Updated changelog
Update regions.cpp
Feature/js upgrade
1. Updated Xcode to match other ides 2. Corrected position errors in Cmake 3. Changed case on cBaseobject.cpp to uppercase O, to match header file 4. Changed gump.h to CGump.h (since it defines the CGump.cpp class).
deleted redundant workflow (build.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on js-upgrade, and orginization pull.
It might have vs2017 deleted (as in my branch, I don't maintain that).
Essentially this just fixes all the stream header usage. Most of UOX3 used if stream/ofstream in the calls. It should have used istream/ostream for the passing. So one could open a string stream, or any other stream, given the lowest base class. For the actual stream you create, that is ifstream/ofstream, but the passing is istream/ostream.
I picked develop since I didn't know what other branch of yours to use. Feel free, or not.
Just code cleanup.