Partialbinaryoverlap - XURI please test this one #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8. Add global flag to global object
xcode updates
added building zlib as optional quieted warnings on cmake build
Consolidated github workflow Added macOS to the workflow Updated readme.md to standardized cmake instructions
Feature/js upgrade
1. Updated Xcode to match other ides 2. Corrected position errors in Cmake 3. Changed case on cBaseobject.cpp to uppercase O, to match header file 4. Changed gump.h to CGump.h (since it defines the CGump.cpp class).
deleted redundant workflow (build.yml)
Change ofstream to generic ostream in calls
async region save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this stores/reads resource[].bin in binary format (even big endian, not sure why the old one was done that way).
It gathers up all the data in formatted text (except resources), and then spawns off async write to file.
Now, the formatted write to text is slow so this may not save that much (but it could change, and put the formatting in the spawned part). Also, using async, so that is hit/miss if really being async or not (threadpool anyone?).
Any way, Xuri, can you please test this?