Неделин Дмитрий - Лабораторная Работа #2 #394
Open
+161
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Реализованная Лабораторная работа #2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 94.09% 94.10%
=======================================
Files 186 186
Lines 6100 6109 +9
=======================================
+ Hits 5740 5749 +9
Misses 360 360 |
| @@ -100,7 +100,7 @@ | |||
| |---|---|---| | |||
| | [Игра "Жизнь" Конвея](https://github.com/garora/TDD-Katas/blob/master/KatasReadme.md#game-of-life-) |Кудинов Никита 3821Б1ПР1|Киселёв Игорь 3821Б1ПР1| | |||
| | [Правило 30](https://en.wikipedia.org/wiki/Rule_30) ||| | |||
| | [Вычисление скидок на книги](https://github.com/garora/TDD-Katas/blob/master/KatasReadme.md#harry-potter-) ||| | |||
| | [Вычисление скидок на книги](https://github.com/garora/TDD-Katas/blob/master/KatasReadme.md#harry-potter-) |Неделин Дмитрий 3821Б1ПР3|Неделин Дмитрий 3821Б1ПР3| | |||
There was a problem hiding this comment.
Suggested change
| | [Вычисление скидок на книги](https://github.com/garora/TDD-Katas/blob/master/KatasReadme.md#harry-potter-) |Неделин Дмитрий 3821Б1ПР3|Неделин Дмитрий 3821Б1ПР3| | |
| | [Вычисление скидок на книги](https://github.com/garora/TDD-Katas/blob/master/KatasReadme.md#harry-potter-) |Неделин Дмитрий 3821Б1ПР3|Неделин Дмитрий 3821Б1ПР3|| |
Comment on lines
+10
to
+16
| class HarryPotterBooks { | ||
| public: | ||
| double calculateTotalPrice(std::vector<int> books); | ||
|
|
||
| const double bookPrice = 8.0; | ||
| const std::vector<double> discounts = { 0.0, 0.0, 0.05, 0.1, 0.2, 0.25 }; | ||
| }; |
There was a problem hiding this comment.
Обработайте случай, если на вход подается пустой вектор
There was a problem hiding this comment.
Добавьте тест, который проверяет случай, когда приходит пустой вектор
|
Please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choice lab