Menu parser #35
Open
Menu parser #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helias
reviewed
Mar 7, 2023
| case _: | ||
| return "ERROR the day selected doesn't exist" | ||
|
|
||
| return menu_of_the_day |
There was a problem hiding this comment.
this entire function is not necessary
Helias
reviewed
Mar 7, 2023
module/menuparser/menu.py
Outdated
Comment on lines
26
to
27
| i_str = str(i) | ||
| current_course = w_s[table_char + i_str].value |
There was a problem hiding this comment.
Suggested change
| i_str = str(i) | |
| current_course = w_s[table_char + i_str].value | |
| current_course = w_s[table_char + str(i)].value |
Helias
reviewed
Mar 7, 2023
module/menuparser/menu.py
Outdated
Comment on lines
25
to
28
| for i in range (4, 15): | ||
| i_str = str(i) | ||
| current_course = w_s[table_char + i_str].value | ||
| menu_of_the_day.append(current_course) |
There was a problem hiding this comment.
or, if you want:
Suggested change
| for i in range (4, 15): | |
| i_str = str(i) | |
| current_course = w_s[table_char + i_str].value | |
| menu_of_the_day.append(current_course) | |
| menu_of_the_day = [w_s[table_char + str(i)].value for i in range (4, 15)] | |
| return menu_of_the_day |
removing the menu_of_the_day = [] at the top of the function
Helias
reviewed
Mar 7, 2023
module/menuparser/menu.py
Outdated
Comment on lines
67
to
68
| for i in range(len(menu_list)): | ||
| print(menu_list[i]) |
There was a problem hiding this comment.
Suggested change
| for i in range(len(menu_list)): | |
| print(menu_list[i]) | |
| for menu_item in menu_list: | |
| print(menu_item) |
Helias
reviewed
Mar 7, 2023
module/menuparser/menu.py
Outdated
Comment on lines
71
to
75
| #Calls to the functions for testing | ||
| table = open_menu(MENU_PATH) | ||
| menu = scroll_table(table, 1) | ||
|
|
||
| print_function(menu) |
There was a problem hiding this comment.
you could wrap this into a if __name__ == "__main__":
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial set up for the menù