Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-8383: Upgrade knex to latest version #258

Merged
merged 3 commits into from
Aug 30, 2024
Merged

HPC-8383: Upgrade knex to latest version #258

merged 3 commits into from
Aug 30, 2024

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Aug 26, 2024

Needs UN-OCHA/hpc-api-core#154 to be merged first.

@Pl217 Pl217 added dependencies Pull requests that update a dependency file ready for review All comments have been addressed, and the Pull Request is ready for review pending prior merge Another Pull Request needs to be merged before this one labels Aug 26, 2024
@Pl217 Pl217 requested a review from a team as a code owner August 26, 2024 14:16
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Pl217 and others added 3 commits August 30, 2024 16:34
The migration guide can be found here
https://github.com/knex/knex/blob/176151d8048b2a7feeb89a3d649a5580786d4f4e/UPGRADING.md

In section "Upgrading to version 0.95.0+", the only
change that affects us is the import style change.

Other sections, regarding upgrades to higher major
versions of Knex, don't have anything that affects us.
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@enxtur enxtur added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Aug 30, 2024
@enxtur enxtur merged commit 47530c9 into develop Aug 30, 2024
5 checks passed
@enxtur enxtur deleted the HPC-8383 branch August 30, 2024 08:39
@Pl217 Pl217 removed the pending prior merge Another Pull Request needs to be merged before this one label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants