Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-8676: Adjust to breaking changes of GitHub Action #257

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Jun 14, 2024

GitHub Action started supporting releasing from a monorepo, which this repository is NOT, but due to breaking changes, we need to make a couple of adjustments here:

  1. Change from docker object to dockerImages array in configuration
  2. Rename path to dockerfilePath

GitHub Action started supporting releasing from a monorepo,
which this repository is NOT, but due to breaking changes,
we need to make a couple of adjustments here:
1) Change from `docker` object to `dockerImages`
array in configuration
2) Rename `path` to `dockerfilePath`
@Pl217 Pl217 added the ready for review All comments have been addressed, and the Pull Request is ready for review label Jun 14, 2024
@Pl217 Pl217 requested a review from a team as a code owner June 14, 2024 15:34
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Delgee Delgee assigned Pl217 and unassigned Delgee Jun 18, 2024
@Delgee Delgee added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Jun 18, 2024
@Pl217 Pl217 merged commit 149a1ad into develop Jun 18, 2024
5 checks passed
@Pl217 Pl217 deleted the HPC-8676 branch June 18, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants