-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦️ Prepare release v4.6.1
and deploy to stage
#226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update develop with changes from env/stage
Update develop with changes from env/stage
The top-level `version` property is defined by the Compose Specification for backward compatibility. It is only informative. https://docs.docker.com/compose/compose-file/04-version-and-name/
Compose generates container names based on the project name, service name, and scale/replica count. In Compose V1, an underscore (_) was used as the word separator. In Compose V2, a hyphen (-) is used as the word separator. https://docs.docker.com/compose/migrate/#service-container-names Since existing container names aren't used anywhere else, just remove them and use default names
This API depends on v3 API to start the database, thus integrated compose file is used, instead of standalone compose file. Even though this file isn't usually used, update Postgres version, as this should have been done in HPC-8969
HPC-9088: Update to Compose V2
unocha-hpc
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker image has been successfully built and pushed as: public.ecr.aws/unocha/hpc-api:v4.6.1-pre
Please deploy this image to a development environment, and test it is working as expected before merging this pull request.
enxtur
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.