-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦️ Prepare release v4.6.0
and deploy to stage
#220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update develop with changes from env/stage
Update develop with changes from env/stage
Node.js v18.18.2 has multiple security fixes, so we don't want earlier versions
We still keep v18 as a valid option, since Dependabot runner image still uses it https://github.com/dependabot/dependabot-core/blob/main/npm_and_yarn/Dockerfile
CodeQL Actions are yet to release v3, which will run on `node20` github/codeql-action#1959
Since ESLint and Typescript are peer dependencies, we need to update them too
This commit is the output of command: `yarn prettier --write .` Prettier plugin uses same feature that VS Code's "Organize import" uses to order the imports
This is done to prepare for flat ESLint config which will be rolled out in v9 https://eslint.org/blog/2023/10/flat-config-rollout-plans
Upon release of v6 of `@typescript-eslint/*` packages, `no-explicit-any` started throwing errors, which is a good default behavior, but not something we're ready to embrace due to lots of `any` usages in generic code typescript-eslint/typescript-eslint#7130
This commit is output of running command: `yarn eslint --quiet --fix .`
HPC-9238: Upgrade to Node.js v20
unocha-hpc
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker image has been successfully built and pushed as: public.ecr.aws/unocha/hpc-api:v4.6.0-pre
Please deploy this image to a development environment, and test it is working as expected before merging this pull request.
Pl217
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.