Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-9238: Upgrade to Node.js v20 #218

Merged
merged 20 commits into from
Nov 6, 2023
Merged

HPC-9238: Upgrade to Node.js v20 #218

merged 20 commits into from
Nov 6, 2023

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Oct 26, 2023

@Pl217 Pl217 added dependencies Pull requests that update a dependency file ready for review All comments have been addressed, and the Pull Request is ready for review labels Oct 26, 2023
@Pl217 Pl217 requested a review from a team as a code owner October 26, 2023 10:16
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Pl217 Pl217 added the pending prior merge Another Pull Request needs to be merged before this one label Oct 26, 2023
Pl217 added 19 commits November 1, 2023 14:28
Node.js v18.18.2 has multiple security fixes,
so we don't want earlier versions
CodeQL Actions are yet to release v3, which will run on `node20`
github/codeql-action#1959
Since ESLint and Typescript are peer
dependencies, we need to update them too
This commit is the output of command:
`yarn prettier --write .`

Prettier plugin uses same feature that
VS Code's "Organize import" uses to
order the imports
This is done to prepare for flat ESLint
config which will be rolled out in v9
https://eslint.org/blog/2023/10/flat-config-rollout-plans
Upon release of v6 of `@typescript-eslint/*` packages,
`no-explicit-any` started throwing errors, which is
a good default behavior, but not something we're ready to
embrace due to lots of `any` usages in generic code

typescript-eslint/typescript-eslint#7130
This commit is output of running command:
`yarn eslint --quiet --fix .`
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Pl217 Pl217 removed the pending prior merge Another Pull Request needs to be merged before this one label Nov 2, 2023
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Delgee Delgee assigned Pl217 and unassigned Delgee Nov 6, 2023
@Delgee Delgee added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Nov 6, 2023
@Pl217 Pl217 merged commit 3a67933 into develop Nov 6, 2023
4 checks passed
@Pl217 Pl217 deleted the HPC-9238 branch November 6, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants