Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-7811 set up test environment #217

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

manelcecs
Copy link
Contributor

This PR aims to add Jest test environment for HPC-API
Also provide a set of initial test for GraphQL

@manelcecs manelcecs self-assigned this Oct 26, 2023
@manelcecs manelcecs requested a review from a team as a code owner October 26, 2023 08:55
@manelcecs manelcecs force-pushed the HPC-7811_set_up_test_environment branch from 992c8f3 to d9ff455 Compare October 26, 2023 09:04
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs assigned Pl217 and unassigned manelcecs Oct 26, 2023
@manelcecs manelcecs added the ready for review All comments have been addressed, and the Pull Request is ready for review label Oct 26, 2023
@manelcecs manelcecs force-pushed the HPC-7811_set_up_test_environment branch from d9ff455 to f206948 Compare November 9, 2023 11:40
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs force-pushed the HPC-7811_set_up_test_environment branch from f206948 to 1c0d811 Compare November 10, 2023 11:05
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Pl217 Pl217 force-pushed the HPC-7811_set_up_test_environment branch from 1c0d811 to cbe05c0 Compare November 17, 2023 14:21
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs force-pushed the HPC-7811_set_up_test_environment branch from cbe05c0 to 7cee992 Compare January 14, 2024 16:07
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased this PR and resolved issues I write about inline. All except the comment about undefined variable $STOP and option -ns, which don't exist, but are mentioned in bin/test.sh.

Also, I have made the following changes:

  • Set up CI to run unit tests
  • Changed Solr config to latest one
  • Use newest DB migration file

bin/test.sh Outdated Show resolved Hide resolved
bin/test.sh Outdated Show resolved Hide resolved
bin/test.sh Outdated Show resolved Hide resolved
tests/docker-compose.yml Outdated Show resolved Hide resolved
tests/docker-compose.yml Outdated Show resolved Hide resolved
bin/test.sh Outdated Show resolved Hide resolved
tests/resolvers/software-info.spec.ts Outdated Show resolved Hide resolved
tests/resolvers/software-info.spec.ts Show resolved Hide resolved
tests/docker-compose.yml Outdated Show resolved Hide resolved
tests/testContext.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 force-pushed the HPC-7811_set_up_test_environment branch from 7cee992 to d422934 Compare March 19, 2024 20:38
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Pl217 Pl217 force-pushed the HPC-7811_set_up_test_environment branch from 4251af4 to b28b2c5 Compare March 20, 2024 12:08
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and @manelcecs have agreed to remove Solr from test containers.

@Pl217 Pl217 merged commit 1797536 into develop Mar 20, 2024
5 checks passed
@Pl217 Pl217 deleted the HPC-7811_set_up_test_environment branch March 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants