Fix validation for 'offset' and 'limit'

UN-OCHA · Mar 13, 2024 · 41fb83b · 41fb83b
1 parent bfc0124
commit 41fb83b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/domain-services/flows/flow-search-service.ts b/src/domain-services/flows/flow-search-service.ts
@@ -849,6 +849,9 @@ export class FlowSearchService {
       }
     }
 
+    args.flowObjectFilters = flowObjectFilters;
+    // default limit to increase performance
+    args.limit = 5000;
     // Do the first search
     const flowSearchResponse = await this.search(
       models,
@@ -870,7 +873,6 @@ export class FlowSearchService {
         databaseConnection,
         nextArgs
       );
-
       flows.push(...nextFlowSearchResponse.flows);
 
       hasNextPage = nextFlowSearchResponse.hasNextPage;

diff --git a/src/domain-services/flows/strategy/impl/search-flow-by-filters-strategy-impl.ts b/src/domain-services/flows/strategy/impl/search-flow-by-filters-strategy-impl.ts
@@ -232,7 +232,7 @@ export class SearchFlowByFiltersStrategy implements FlowSearchStrategy {
 
     // Then we are going to slice the flows using the limit and offset
     let reducedFlows: UniqueFlowEntity[];
-    if (offset && limit) {
+    if (offset !== undefined && limit !== undefined) {
       reducedFlows = sortedFlows.slice(offset, offset + limit);
     } else {
       reducedFlows = sortedFlows;