Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UKVIC-151 Remove "Not Yet" response from "Refund" category - DO NOT MERGE #232

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ChisomOguibe11
Copy link
Contributor

Task:

When selecting the "Refund" option, users are asked if they have requested a refund and the options are "Yes", "Not Yet" and "No, I was told refund would be automatic".

Business have agreed that the "Not Yet" option should be removed.

Changes:

  • Comment out all tests that used the refund "Not yet option"
  • Remove "Not yet" field in Refund form

Reference:

https://collaboration.homeoffice.gov.uk/jira/browse/UKVIC-151

Then I should see 'Date of birth' and '1981-01-01' on the page
Then I should see 'Email address' and ' [email protected]' on the page
Then I should see 'Phone number (optional)' and '(optional) 02079462345' on the page
# Scenario: I am on the Refunds (refunds) journey, I am acting on behalf of myself and want to complain
Copy link
Contributor

@shamiluwais shamiluwais Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove these tests if it is not required any more

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks shamil, will remove the commented out tests since they are not needed

Copy link
Contributor

@shamiluwais shamiluwais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend removing commented out code.

@@ -26,6 +26,7 @@ describe('getRefundComplaint', () => {
).to.eql('YES');
});

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could delete this if not required

@ChisomOguibe11 ChisomOguibe11 removed the request for review from RobertMcCann February 17, 2023 14:04
@Alex-Swann Alex-Swann changed the base branch from main to master February 20, 2023 12:54
@ChisomOguibe11 ChisomOguibe11 changed the title Remove "Not Yet" response from "Refund" category - DO NOT MERGE UKVIC-151 Remove "Not Yet" response from "Refund" category - DO NOT MERGE Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants