SD 272: decs integration

.drone.yml

@@ -6,12 +6,12 @@ type: kubernetes
 steps:
 - name: build
   pull: if-not-exists
-  image: node:10
+  image: node:14
   commands:
   - npm --loglevel warn install
   - npm run test
   when:
-    branch: [ master, features/* ]
+    branch: [ master, feature/* ]
     event: push
 
 - name: build_ukvi-complaints
@@ -21,7 +21,7 @@ steps:
   - n=0; while [ "$n" -lt 60 ] && [ ! docker stats --no-stream ]; do n=$(( n + 1 )); sleep 1; done
   - docker build -t app-$${DRONE_COMMIT_SHA} .
   when:
-    branch: [ master, features/* ]
+    branch: [ master, feature/* ]
     event: push
 
 - name: image_to_quay
@@ -50,8 +50,7 @@ steps:
   commands:
     - git clone https://$${DRONE_GIT_USERNAME}:$${DRONE_GIT_TOKEN}@github.com/UKHomeOffice/kube-ukvi-complaints.git
     - cd kube-ukvi-complaints
-    - git tag dev-${DRONE_COMMIT_SHA}
-    - git push origin --tags
+    - if ! [ $(git tag -l dev-${DRONE_COMMIT_SHA}) ]; then git tag dev-${DRONE_COMMIT_SHA} && git push origin --tags; fi
   when:
     branch: master
     event: push
@@ -67,8 +66,7 @@ steps:
   commands:
     - git clone https://$${DRONE_GIT_USERNAME}:$${DRONE_GIT_TOKEN}@github.com/UKHomeOffice/kube-ukvi-complaints.git
     - cd kube-ukvi-complaints
-    - git tag ${DRONE_DEPLOY_TO}-${DRONE_COMMIT_SHA}
-    - git push origin --tags
+    - if ! [ $(git tag -l ${DRONE_DEPLOY_TO}-${DRONE_COMMIT_SHA}) ]; then git tag ${DRONE_DEPLOY_TO}-${DRONE_COMMIT_SHA} && git push origin --tags; fi
   when:
     event: promote
     target: [ preprod, prod ]
@@ -101,7 +99,7 @@ steps:
       from_secret: kube_server_dev
     KUBE_TOKEN_DEV:
       from_secret: kube_token_dev
-    KUBE_NAMESPACE: ukvi-complaints-preprod
+    KUBE_NAMESPACE: sas-ukvi-complaints-preprod
     APP_IMAGE_TAG: ${DRONE_COMMIT_SHA}
   when:
     event: promote

.eslintignore

@@ -7,3 +7,5 @@ apps/**/acceptance/**/*.js
 LICENSE
 README.md
 CONTRIBUTING.md
+test/executions
+test/coverage

.eslintrc

@@ -3,3 +3,27 @@ extends:
 
 env:
   es6: true
+  mocha: true
+
+overrides:
+- files:
+    "test/**/*.js"
+  rules:
+    implicit-dependencies/no-implicit: [error, { dev: true }]
+    max-nested-callbacks: off
+    complexity: [error, 40]
+  globals:
+    chai: true
+    sinon: true
+    expect: true
+    proxyquire: true
+    browser: true
+    page: true
+    baseURL: true
+    submitPage: true
+    getErrorSummaries: true
+    getErrorMessages: true
+- files:
+    "apps/ukvi-complaints/behaviours/*.js"
+  rules:
+    complexity: [error, 40]

.gitignore

@@ -1,7 +1,12 @@
 .DS_Store
-apps/*/translations/en
-node_modules
+node_modules/
 public
-npm-debug.log
+apps/*/translations/*
+!apps/*/translations/src
 .idea
+.DS_Store
+apps/.DS_Store
+.nyc_output
 .env
+test/executions
+test/coverage

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:10-alpine
+FROM node:14-alpine
 
 RUN apk upgrade --no-cache
 RUN addgroup -S app

README.md

@@ -2,6 +2,7 @@
 
 ## Getting started
 
+
 Get the project from Github
 ```bash
 $ git clone [email protected]:UKHomeOffice/UKVI-Complaints.git && cd UKVI-Complaints
@@ -19,6 +20,37 @@ Run the services locally with Docker Compose
 $ docker-compose up
 ```
 
+
+### Set up AWS SQS queue locally
+
+Run AWS services locally using localstack.
+
+```bash
+$ docker run --rm -p 4566:4566 -p 4571:4571 localstack/localstack
+```
+
+To create an SQS queue on the localstack instance.
+```bash
+aws \
+sqs create-queue \
+--queue-name local-queue \
+--endpoint-url http://localhost:4566 \
+--region eu-west-2
+```
+
+This will return a url, add this is the url of the localstack sqs queue: 
+```
+http://localhost:4566/000000000000/local-queue
+```
+
+To view what is on the queue currently run:
+```bash
+aws --endpoint-url=http://localhost:4566 --region eu-west-2 sqs receive-message --queue-url http://localhost:4566/000000000000/local-queue --max-number-of-messages 10
+```
+
+
+### Running in dev
+
 Getting your hands dirty (You'll need [Redis](http://redis.io/) for this)
 ```bash
 $ npm run dev

apps/ukvi-complaints/behaviours/caseworker-email.js

@@ -4,6 +4,7 @@ const Emailer = require('hof-behaviour-emailer');
 const path = require('path');
 const moment = require('moment');
 
+// eslint-disable-next-line complexity
 const getDataRows = (model, translate) => {
   return [
     {
@@ -216,8 +217,11 @@ module.exports = config => {
     // eslint-disable-next-line no-console
     console.warn('WARNING: Email `from` address must be provided. Falling back to stub email transport.');
   }
+
+  const transport = config.emailCaseworker ? config.transport : 'stub';
+
   return Emailer(Object.assign({}, config, {
-    transport: config.from ? config.transport : 'stub',
+    transport: config.from ? transport : 'stub',
     recipient: config.caseworker,
     subject: (model, translate) => translate('pages.email.caseworker.subject'),
     template: path.resolve(__dirname, '../emails/caseworker.html'),

apps/ukvi-complaints/behaviours/conditional-content.js

@@ -1,6 +1,8 @@
+'use strict';
+
 module.exports = superclass => class extends superclass {
 
-	locals (req, res, next) {
+	locals(req, res, next) {
 		res.locals.isBehaviourIssue = req.form.values.reason === 'staff-behaviour';
 		res.locals.isRefundIssue = req.form.values.reason === 'refund';
 		res.locals.isApplicationIssue = req.form.values.reason === 'immigration-application';

apps/ukvi-complaints/behaviours/customer-email.js

@@ -4,6 +4,7 @@ const Emailer = require('hof-behaviour-emailer');
 const path = require('path');
 const moment = require('moment');
 
+// eslint-disable-next-line complexity
 const getDataRows = (model, translate) => {
   return [
     {

apps/ukvi-complaints/behaviours/send-to-sqs.js

@@ -0,0 +1,41 @@
+'use strict';
+const Validator = require('jsonschema').Validator;
+const config = require('../../../config');
+const { validAgainstSchema, sendToQueue } = require('../lib/utils');
+const formatComplaintData = require('../lib/format-complaint-data');
+
+module.exports = superclass => class SendToSQS extends superclass {
+
+  // eslint-disable-next-line consistent-return
+  saveValues(req, res, next) {
+    try {
+      if (!config.sendToQueue) {
+        return next();
+      }
+
+      const complaintData = formatComplaintData(req.sessionModel.attributes);
+
+      if (validAgainstSchema(complaintData, new Validator())) {
+        return sendToQueue(complaintData)
+          .then(() => {
+            next();
+          })
+          .catch(err => {
+            SendToSQS.handleError(next, err);
+          });
+      }
+    } catch (err) {
+      SendToSQS.handleError(next, err);
+    }
+  }
+
+
+  static handleError(next, err) {
+    err.formNotSubmitted = true;
+    // eslint-disable-next-line no-console
+    console.error(err);
+    return next(err);
+  }
+
+};
+