Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all dependency updated to LTS. #51

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

all dependency updated to LTS. #51

wants to merge 16 commits into from

Conversation

farrukhishaq
Copy link

@farrukhishaq farrukhishaq commented Oct 21, 2024 •
edited
Loading

All Dependencies are updated

    "express": "^4.21.1",
    "node-sass-middleware": "^1.1.0",
    "nunjucks": "^3.2.4",
    "sass-lint": "^1.13.1"
    "govuk-frontend": "^5.7.1"

Change Affect/ Manual test

  • No obvious difference noticed.
  • Landed to various pages and components.
  • e-2-e test are not passing in local so we want this to be test in the dev env.

@farrukhishaq farrukhishaq added the major backwards incompatible change label Oct 21, 2024
@farrukhishaq farrukhishaq requested a review from a team October 21, 2024 09:45
farrukhishaq
farrukhishaq commented Oct 22, 2024
View reviewed changes
assets/styles/_colours.scss Outdated
@@ -3,6 +3,10 @@ $ho-brand: #8f23b3;
$black: #0b0c0c;
$white: #fff;
$background: #f3f3f3;
$grey-1: #6F777B;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

govuk-colour('grey-1')

replaced with $grey-1 in all-components/ asl pages/projects

farrukhishaq
farrukhishaq commented Oct 22, 2024
View reviewed changes
assets/styles/_govuk-frontend.scss Outdated
@import 'govuk-frontend/dist/govuk/core/all';
@import 'govuk-frontend/dist/govuk/objects/all';

@import 'govuk-frontend/dist/govuk/overrides/all';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using complete path as a breaking change using dist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-horton-ho-sas jeff-horton-ho-sas jeff-horton-ho-sas approved these changes

@parvinba parvinba parvinba approved these changes

Assignees
No one assigned
Labels
major backwards incompatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farrukhishaq @jeff-horton-ho-sas @parvinba