EPP-99: Add 755 permission to bash files #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Permission issues have been restricting scripts from executing in pipeline * Checked with other services and changed to 755 * Added Missing drone and Docker Ignore files * prevents adding unwanted files to the images and reduces the image build time
* Docker Daemon can take 60 Seconds to start * Drone pipeline complaining of Docker Daemon not starting * this is same as using - n=0; while [ "$n" -lt 60 ] && ! docker stats --no-stream >/dev/null 2>&1; do n=$(( n + 1 )); sleep 1; done * ACP documentations supports us to use this instead https://docs.acp.homeoffice.gov.uk/how-to/drone-ci/#docker-in-docker
* ACP documented solution havent resolved the issue * Now we are using the commands used in build_image step to wait for docker daemon to start.
* Add pull if not exists to avoid unnecessarily pulling existing image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing?
As we cant wait for scheduled time to execute cron jobs. We can run the cron jobs manually. I can test from this feature branch once tested will merge to master branch and do testing again for one final time. We are also testing the slack webhook to send payload to respective slack channels
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit