User/marcelo/aux bmsv2 electrical requests #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should double check DMA, ADC and SPI settings
Only difficulty is that for CMSIS v2, CubeMx does not support memory pools so we are assuming we'll be fine with just queues. Worst case, we'll use pvMalloc and pvFree for dynamic allocation.
Created functions, tasks, and unit tests relating to contactor control.
Implemented stack overflow hook, and malloc failed hook, and error handler
created test for updateAuxTrip Fix TripTest.c Add two more tests for updateAuxTrip Fix unneccessary way of calling checkProtectionTrip Run remaining tests Split tripDuetoHighTempAndCurrent into two variables Removing checkProtectionTrip() Simplify checkDischargeTrip and checkChargeTrip add mocks for trip Redoing OrionInterfaceTest Add shouldDisconnectContactors test Finish tests
…he old code we take in multiple adc reads and check if they're stable before we actually use that for calculation. Wrote code for that
… queue, added function to check if orion is happy before setting the common contactor in startup task, change to only execute the orionInterface function if orion is happy before startup happens, changed orion interface to only disconnect contactor once start up is done which we set the variable in discharge contactor gatekeeper because the contactorStatusUpdate function is not running. This is very ghetto and will need to be fixed however at this point the AuxBMS should be useable
…ick not SysTick as delay func and macros are based on TaskTicks
* discharge trip due to isCurrentLow being false * SFT-329 Is Current Low Trip Condition implemented tripping if current line between contactors is too low to close charge or discharge * add canqueudata
…ng Orion data, have it so StrobeBMSLights only turn on after start up, and increasaed lowCurrent treshold to account for new relays
…protection trips when only common is closed or whenever a contactor is being closed, implemented check for manual charge trip but not being used in charge trip logic
…a retry or a check, added functionality to open charge from the spare toggle button, changed orionInterface logic to isolate charge and discharge closing without having a race condition, neither will trigger the other to close if it closes successfully anymore
…ggle button for opening charge manually
…ionGood function to update AuxTrip and AuxStatus while also turning the StrobeLights after a number of failed attempts to close commmon
…sured permanence for StrobeLights and CAN trips
…dded trip for contactor openning suddenly
…ockout when both contactors want to close
…verwriting of previous trip values
…for some reason except it makes no logical sense, keeping it there for now until further investigation
…HappyForStartUp resets AuxTrip and Strobe lights if startup sequence can begin
…n trying to engage
…nd discharge engaging, fixed bug where we allow charge and discharge even if contactors are not engaged, added check for charge contactor when engaging solar arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new contactor to isolate solar arrays from charge line
Reworked startup sequence
Added trips for Orion message timeout and for current too high in relay line.
Started logging contactor disconnected unexpectedly trip
Ensured permanence of trips and strobe lights
Allowed discharge and charge only when the respective contactors are closed