Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFT-327 Trip if you don’t have messages from the orion after 400ms #195

Open
wants to merge 3 commits into
base: user/Dillonsd/AuxBMSTesting
Choose a base branch
from

Conversation

brian-ngyn
Copy link
Member

No description provided.

* discharge trip due to isCurrentLow being false

* SFT-329 Is Current Low Trip Condition implemented tripping if current line between contactors is too low to close charge or discharge

* add canqueudata
@brian-ngyn brian-ngyn changed the base branch from master to user/Dillonsd/AuxBMSTesting June 3, 2022 01:31
Copy link
Member

@JessieG123 JessieG123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sealofapproval

Copy link
Contributor

@VioletLiGonzales VioletLiGonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 would review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants