Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) disable Auto opening of Clinical-forms-workspace on form cancellation #1925

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

kajambiya
Copy link
Contributor

@kajambiya kajambiya commented Sep 10, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Whenever a form is cancelled, the clinical-forms-workspace is automatically opened. This however shouldn't be the case if the form wasn't opened from the clinical-forms-workspace in the first place. This PR seeks to resolve the issue.

Screenshots

Before:

Screen.Recording.2024-09-10.at.16.19.38.mov

After:

Screen.Recording.2024-09-10.at.16.18.50.mov

Related Issue

Other

Copy link
Contributor

@ODORA0 ODORA0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kajambiya LGTM
Would be good if you added a screen recording of this change

@kajambiya kajambiya merged commit 3e450ea into UCSF-IGHS:dev Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants