Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-1974_Add numbered page buttons to SectionPagination #647

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Oct 25, 2024

Connected to APPS-1974

Component Updated: SectionPagination.vue

Stories: ~/stories/SectionPagination.stories.js

Spec: ~/stories/SectionPagination.spec.js

Notes:

In progress

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@farosFreed farosFreed self-assigned this Oct 25, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

@farosFreed farosFreed changed the title APPS-1974_Add numbered page buttons to SectionPagination feat: APPS-1974_Add numbered page buttons to SectionPagination Oct 25, 2024
@farosFreed farosFreed added the feature feature label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant