feat: "type" filter for Services & Resources #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
|
🚀 Deployed on https://deploy-preview-736--uclalibrary-test.netlify.app |
sourcefilter
force-pushed
the
service-resource-filters
branch
from
0153aa4
to
813dfde
Compare
sourcefilter
force-pushed
the
service-resource-filters
branch
from
813dfde
to
8736fc9
Compare
pghorpade
requested changes
Sep 8, 2023
| (this.$route.query.filters && | ||
| queryFilterHasValues( | ||
| this.$route.query.filters, | ||
| config.eventsExhibitionsList.filters |
There was a problem hiding this comment.
need to use serviceorresources filters
pghorpade
requested changes
Sep 8, 2023
sourcefilter
force-pushed
the
service-resource-filters
branch
from
1d5458e
to
8217b51
Compare
sourcefilter
force-pushed
the
service-resource-filters
branch
from
8217b51
to
09c393a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.