Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-2403 buttonurl is not required if the program URL behaviour is external #731

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

pghorpade
Copy link
Contributor

Connected to APPS-2403

@pghorpade pghorpade self-assigned this Aug 24, 2023
@github-actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

@github-actions github-actions bot temporarily deployed to pull_request-731 August 24, 2023 19:02 Inactive
Copy link
Member

@jendiamond jendiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@jendiamond jendiamond merged commit 60c6215 into main Aug 24, 2023
6 checks passed
@jendiamond jendiamond deleted the APPS-2403 branch August 24, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants