-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: JupyterLite integration #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! It works almost perfectly!
Some things to improve:
- keep directories structure
geopy
doesn't work, though it's part of the requirements. Do you know what cold be producing that?- I'd like to get a menu next to download notebook / like
run notebook
or jupyterlite icon, but that is in the theme repository. We can do it after we fix the other things.
Co-authored-by: David Pérez-Suárez <[email protected]>
Hmm, this is weird, looking into it. |
I looked into this, and turns out jupyterlite does not really read dependencies from the existing environment. We can either Ship additional Pyodide wheels at build time or add a |
Hi there, if either of you would like to add and maintain |
Thanks for the suggestion! One thing that I was looking at (after you shared it) was Creating a Pyodide package. The guide says -
Given that geopy is a pure Python package, should it be added as a "package" in Pyodide? |
Yes, to avoid the usual answer of "it depends": I think it's sometimes good to add pure Python packages to Pyodide, and many of them exist – especially those in Python's scientific computing ecosystem. For example, Zarr is a pure Python package, but it relies on async programming functionality, which means that it's good to include it and test it from time to time. I see that Additing it would constrain you to use the version of it available with the Pyodide version, though, unless you disable installing it and ask for the one to be used from PyPI explicitly. If that's a bother and you would like to keep using the latest versions available on PyPI for your convenience, then you may skip doing this. Nevertheless, it would be required to add it if |
Thanks for the details! geopy, in fact, is not working out of the box in jupyterlite. I have created an issue in their repository, but it looks like the development there has stalled? I'll keep a look if I get any replies from them. |
c223cbc
to
411c94e
Compare
411c94e
to
b596bf8
Compare
Copying from geopy/geopy#578
Added comments to mark bash and requests failure on the browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thank you for all this!!
Closes #250
@dpshelio the preview for this is available on my fork - https://saransh-cpp.github.io/rsd-engineeringcourse.
Going to https://saransh-cpp.github.io/rsd-engineeringcourse/jupyter-lite will redirect the users to -
I couldn't embed the page within the original website + all the examples having these embedded kernels are out of date/have switched to the non-embedded format (like the one in this PR).
For adding a button adjacent to "Notebook download" button, should I make a PR to the theme repository, making changes somewhere around here -
https://github.com/dpshelio/indigo-jekyll/blob/7d12d6e04f79bbb97aa59f416746409391d0cbaf/_includes/base.html#L153