Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run lcov on MacOS #347

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Don't run lcov on MacOS #347

merged 1 commit into from
Sep 26, 2023

Conversation

samcunliffe
Copy link
Member

@samcunliffe samcunliffe commented Sep 22, 2023

Turns off lcov on the MacOS CI job. (It's failing due to some line number mismatch. Likely an upstream problem. And we definitely don't have the capacity to dive into this right now.

@samcunliffe samcunliffe added bug Something isn't working technical Technical and meta issues, not related to physics but infrastructure. upstream Related to one of our dependencies labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fd221e9) 26% compared to head (435e658) 26%.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #347   +/-   ##
===================================
  Coverage    26%    26%           
===================================
  Files        84     84           
  Lines      3704   3704           
===================================
  Hits        950    950           
  Misses     2754   2754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willGraham01 willGraham01 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 76b005f Sep 26, 2023
21 checks passed
@willGraham01 willGraham01 deleted the lcov-only-on-ubuntu branch September 26, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical Technical and meta issues, not related to physics but infrastructure. upstream Related to one of our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants