Hackathon additions #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dolly Chen <[email protected]>
Co-authored-by: Lawrence Binding <[email protected]>
Co-authored-by: Lawrence Binding <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sfmig
approved these changes
Jan 16, 2025
| help="Input frame number to render", | ||
| ) | ||
|
|
||
| # LB: Add basename |
| "-o", | ||
| "--output", | ||
| "-b", | ||
| "--basename", |
There was a problem hiding this comment.
Is this a prefix for the exported frames, or for the blender file?
Maybe the name and help can be changed to explain this a bit more
| # bpy.ops.preferences.addon_install(filepath=p) | ||
| # if addon_name not in bpy.context.preferences.addons: | ||
| # bpy.ops.preferences.addon_enable(module=addon_name) | ||
| print(p) |
There was a problem hiding this comment.
Should this and the following print statement be removed? (are they debugging remains?)
Comment on lines
+151
to
+155
| # LB if its already installed don't do anything | ||
| # if addon_name not in bpy.context.preferences.addons: | ||
| # bpy.ops.preferences.addon_install(filepath=p) | ||
| # if addon_name not in bpy.context.preferences.addons: | ||
| # bpy.ops.preferences.addon_enable(module=addon_name) |
There was a problem hiding this comment.
Suggested change
| # LB if its already installed don't do anything | |
| # if addon_name not in bpy.context.preferences.addons: | |
| # bpy.ops.preferences.addon_install(filepath=p) | |
| # if addon_name not in bpy.context.preferences.addons: | |
| # bpy.ops.preferences.addon_enable(module=addon_name) |
Since it is commented out?
| print("HERE") | ||
| # RENDERING | ||
| # Randomise geometry | ||
| bpy.ops.node.randomise_all_geometry_sockets("INVOKE_DEFAULT") |
There was a problem hiding this comment.
It seems like this script has been repurposed to run rendering - so maybe the name should be changed?
There was a problem hiding this comment.
I was further confused cause there is another script called "scripts/install_and_enable_addons_render.py" -- maybe these two scripts could be made more distinct?
| active_obj = obj | ||
| elif "Sphere" in str(obj): | ||
| active_obj = obj | ||
| # obj = bpy.data.objects[3] #Sphere |
There was a problem hiding this comment.
Suggested change
| # obj = bpy.data.objects[3] #Sphere |
Comment on lines
+334
to
+353
| ### MATERIALS | ||
| # if args.output is not None: | ||
| # out_path_to_file = args.output[0] | ||
| # with open(out_path_to_file, "r") as in_file_obj: | ||
| # text = in_file_obj.read() | ||
| # # convert the text into a dictionary | ||
| # out_data = json.loads(text) | ||
|
|
||
| # out_data["materials"] | ||
| # print("Output file for key names provided") | ||
|
|
||
| # # Based on ouput file dictionary keys | ||
| # # TODO: - use output file keys and type of values | ||
| # # to replicated code below | ||
|
|
||
| # else: | ||
| # print( | ||
| # "No Output file for key names \ | ||
| # provided - generate from .blend file objects" | ||
| # ) |
There was a problem hiding this comment.
Suggested change
| ### MATERIALS | |
| # if args.output is not None: | |
| # out_path_to_file = args.output[0] | |
| # with open(out_path_to_file, "r") as in_file_obj: | |
| # text = in_file_obj.read() | |
| # # convert the text into a dictionary | |
| # out_data = json.loads(text) | |
| # out_data["materials"] | |
| # print("Output file for key names provided") | |
| # # Based on ouput file dictionary keys | |
| # # TODO: - use output file keys and type of values | |
| # # to replicated code below | |
| # else: | |
| # print( | |
| # "No Output file for key names \ | |
| # provided - generate from .blend file objects" | |
| # ) | |
| filepath=str(output_path) | ||
| ) | ||
|
|
||
| # bpy.ops.render.render(write_still=True) |
There was a problem hiding this comment.
Suggested change
| # bpy.ops.render.render(write_still=True) |
There was a problem hiding this comment.
(and same for other one-lines commented out below)
Comment on lines
+494
to
+500
| # Set resolution and format | ||
| # bpy.context.scene.render.resolution_x = 554 | ||
| # bpy.context.scene.render.resolution_y = 448 | ||
| # bpy.context.scene.render.image_settings.file_format = 'PNG' | ||
|
|
||
| # Ensure render engine is set | ||
| # bpy.context.scene.render.engine = 'CYCLES' # or 'BLENDER_EEVEE' |
There was a problem hiding this comment.
Suggested change
| # Set resolution and format | |
| # bpy.context.scene.render.resolution_x = 554 | |
| # bpy.context.scene.render.resolution_y = 448 | |
| # bpy.context.scene.render.image_settings.file_format = 'PNG' | |
| # Ensure render engine is set | |
| # bpy.context.scene.render.engine = 'CYCLES' # or 'BLENDER_EEVEE' |
Comment on lines
+509
to
+515
| ##bpy.context.scene.render.filepath = str(output_path) | ||
|
|
||
| # Render the image | ||
| # bpy.ops.render.render(write_still=True) | ||
|
|
||
|
|
||
| # %% Helper functions |
There was a problem hiding this comment.
Suggested change
| ##bpy.context.scene.render.filepath = str(output_path) | |
| # Render the image | |
| # bpy.ops.render.render(write_still=True) | |
| # %% Helper functions |
sfmig
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.