82 fix sending out emails #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
stefpiatek
reviewed
Jun 27, 2024
| else: | ||
| logger.info("No suitable token exists in cache. Let's initiate interactive login.") | ||
| auth_code_flow = app.initiate_auth_code_flow(scopes=[self.settings.scope], login_hint=self.settings.username) | ||
| final_url = click.prompt( |
There was a problem hiding this comment.
I think you can change this to click.confirm so you what the temrinal asks you to do makes more sense
src/rred_reports/reports/auth.py
Outdated
| with cache_path.open("wb") as cache_file: | ||
| cache_file.write(cache.serialize()) | ||
|
|
||
| save_cache() |
There was a problem hiding this comment.
Oh interesting. I'm surprised this actually works saving it before we're authenticated. Would have thought you'd have to save the data to the cache file after we've done the manual 2FA flow?
stefpiatek
force-pushed
the
82-fix-sending-out-emails
branch
from
04a276c
to
4cc88bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email sending with MFA in
auth.pyand updatedREADME